Test with custom install dir #10048
Open
Test with custom install dir #10048
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One test fails, but it seems not to be related to this change. |
samypr100
reviewed
Dec 21, 2024
crates/uv/tests/it/help.rs
Outdated
Comment on lines
455
to
458
| if env::var("UV_PYTHON_INSTALL_DIR").is_ok() { | ||
| // skip this test | ||
| return; | ||
| } |
There was a problem hiding this comment.
Note, you can use instead
uv_snapshot!(context.filters(), context.help().env_remove(EnvVars::UV_PYTHON_INSTALL_DIR).arg("python").arg("install"), @r###"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing with
UV_PYTHON_INSTALL_DIRenvironment variable has some problems. This PR fix them.UV_PYTHON_INSTALL_DIRmust be an absolute path.UV_PYTHON_INSTALL_DIRis set, the test fails.Test Plan
All tests pass with
UV_PYTHON_INSTALL_DIR=/path/to/my/home/uv/target/testpython.